On Tue, May 24, 2011 at 08:15:52AM -0400, Daniel Kang wrote:
>
> From 12396e3fa48555f5753511561195a070ba1384ef Mon Sep 17 00:00:00 2001
> From: Daniel Kang <[email protected]>
> Date: Mon, 16 May 2011 19:12:01 -0400
> Subject: [PATCH] Add h264_idct_10.asm
The filename is a bit nondescript as commit message subject.
Something like
Add IDCT functions for 10-bit H.264.
would likely be better.
> --- a/libavcodec/x86/Makefile
> +++ b/libavcodec/x86/Makefile
> @@ -14,6 +14,7 @@ YASM-OBJS-$(CONFIG_H264DSP) +=
> x86/h264_deblock.o \
> x86/h264_deblock_10bit.o \
> x86/h264_weight.o \
> x86/h264_idct.o \
> + x86/h264_idct_10bit.o \
This is supposed to be in alphabetical order.
Please restore alphabetical order while you're at it.
> diff --git a/libavcodec/x86/h264_idct_10bit.asm
> b/libavcodec/x86/h264_idct_10bit.asm
> new file mode 100755
> index 0000000..4bf865f
This is Windows messing with permissions again. Source code should not
be executable.
> --- /dev/null
> +++ b/libavcodec/x86/h264_idct_10bit.asm
> @@ -0,0 +1,434 @@
> +INIT_AVX
> +IDCT8_ADD4 avx
> +%endif
> \ No newline at end of file
This is not allowed, our pre-commit hooks forbid files without ending
newlines. Please fix your editor.
> --- a/libavcodec/x86/h264dsp_mmx.c
> +++ b/libavcodec/x86/h264dsp_mmx.c
> @@ -428,7 +461,18 @@ void ff_h264dsp_init_x86(H264DSPContext *c, const int
> bit_depth)
> c->h264_h_loop_filter_luma_intra =
> ff_deblock_h_luma_intra_10_sse2;
> #endif
> }
> +#if HAVE_AVX
> if (mm_flags&AV_CPU_FLAG_AVX) {
> + c->h264_idct_dc_add =
> + c->h264_idct_add = ff_h264_idct_add_10_avx;
> + c->h264_idct8_add = ff_h264_idct8_add_10_avx;
> + c->h264_idct8_dc_add = ff_h264_idct8_dc_add_10_avx;
> +
> + c->h264_idct_add16 = ff_h264_idct_add16_10_avx;
> + c->h264_idct8_add4 = ff_h264_idct8_add4_10_avx;
> + c->h264_idct_add8 = ff_h264_idct_add8_10_avx;
> + c->h264_idct_add16intra= ff_h264_idct_add16intra_10_avx;
> +
> c->h264_v_loop_filter_chroma= ff_deblock_v_chroma_10_avx;
> c->h264_v_loop_filter_chroma_intra=
> ff_deblock_v_chroma_intra_10_avx;
> #if HAVE_ALIGNED_STACK
> @@ -438,6 +482,7 @@ void ff_h264dsp_init_x86(H264DSPContext *c, const int
> bit_depth)
> c->h264_h_loop_filter_luma_intra =
> ff_deblock_h_luma_intra_10_avx;
> #endif
> }
> +#endif
> }
> }
> #endif
Please add a comment to the '#endif', it's getting tricky to tell
which #endif belongs to which '#if'.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
