Hi, On Tue, May 24, 2011 at 12:14 PM, Luca Barbato <[email protected]> wrote: > On 05/24/2011 05:33 PM, Ronald S. Bultje wrote: >> diff --git a/libavutil/cpu_internal.h b/libavutil/cpu_internal.h >> new file mode 100644 >> index 0000000..f7ee5d0 >> --- /dev/null >> +++ b/libavutil/cpu_internal.h >> @@ -0,0 +1,46 @@ >> +/* >> + * Copyright (c) 2000, 2001, 2002 Fabrice Bellard >> + * >> + * This file is part of Libav. >> + * >> + * Libav is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU Lesser General Public >> + * License as published by the Free Software Foundation; either >> + * version 2.1 of the License, or (at your option) any later version. >> + * >> + * Libav is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + * Lesser General Public License for more details. >> + * >> + * You should have received a copy of the GNU Lesser General Public >> + * License along with Libav; if not, write to the Free Software >> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 >> USA >> + */ >> + >> +#ifndef AVUTIL_CPU_INTERNAL_H >> +#define AVUTIL_CPU_INTERNAL_H >> + >> +#include "config.h" >> + >> +/** >> + * Empty mmx state. >> + * this must be called between any dsp function and float/double code. >> + * for example sin(); dsp->idct_put(); emms_c(); cos() >> + */ >> +#define emms_c() >> + >> +#if HAVE_MMX >> + >> +#undef emms_c >> + >> +static inline void emms(void) >> +{ >> + __asm__ volatile ("emms;":::"memory"); >> +} >> + >> +#define emms_c() emms() >> + >> +#endif /* HAVE_MMX */ >> + >> +#endif /* AVUTIL_CPU_INTERNAL_H */ > > Looks ok, is it a private function? what about adding ff_ ?
It's a macro or inline function, so it's not visible in our library. Therefore, we don't need to prefix it. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
