[I'm not used to the reply-to-author vs. reply-to-list policy, resending]
In data Tuesday 2011-05-24 19:54:11 +0200, Anton Khirnov ha scritto:
> On Tue, 24 May 2011 19:28:48 +0200, Stefano Sabatini
> <[email protected]> wrote:
[...]
> > > @@ -90,10 +93,12 @@ static int dv1394_read_header(AVFormatContext *
> > > context, AVFormatParameters * ap
> > > if (!dv->dv_demux)
> > > goto failed;
> > >
> > > - if (ap->standard && !strcasecmp(ap->standard, "pal"))
> > > - dv->format = DV1394_PAL;
> > > - else
> > > - dv->format = DV1394_NTSC;
> > > + if (ap->standard) {
> > > + if (!strcasecmp(ap->standard, "pal"))
> > > + dv->format = DV1394_PAL;
> > > + else
> > > + dv->format = DV1394_NTSC;
> > > + }
> > >
> > > if (ap->channel)
> > > dv->channel = ap->channel;
> > > @@ -227,6 +232,20 @@ static int dv1394_close(AVFormatContext * context)
> > > return 0;
> > > }
> > >
> > > +static const AVOption options[] = {
> > > + { "standard", "", offsetof(struct dv1394_data, format),
> > > FF_OPT_TYPE_INT, {.dbl = DV1394_NTSC}, DV1394_PAL, DV1394_NTSC,
> > > AV_OPT_FLAG_DECODING_PARAM, "standard" },
> > > + { "PAL", "", 0, FF_OPT_TYPE_CONST, {.dbl = DV1394_PAL}, 0, 0,
> > > AV_OPT_FLAG_DECODING_PARAM, "standard" },
> > > + { "NTSC", "", 0, FF_OPT_TYPE_CONST, {.dbl = DV1394_NTSC}, 0, 0,
> > > AV_OPT_FLAG_DECODING_PARAM, "standard" },
> >
> > This is changing the case, thus possibly causing commandline
> > regressions with -tvstd (note: opt.c uses strcmp). Anyway I'm not
> > strong about this, and -tvstd should be dropped soon or later.
>
> Huh? AVFormatParameter handling is still the same -- case
> insensitive. The new private option is case sensitive (should be changed
> maybe), but that can't be incompatible with anything.
>
> And yes, -tvstd is going away soon.
I was thinking about the case:
-tvstd pal => set PAL
-standard pal => error
but indeed since they have different names this shouldn't be an issue.
--
It matters not whether you win or lose; what matters is whether II win or lose.
-- Darrin Weinberg
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
