Hi,
On Fri, May 27, 2011 at 12:09 PM, Kostya <[email protected]> wrote:
> On Fri, May 27, 2011 at 11:44:49AM -0400, Ronald S. Bultje wrote:
>> ---
>> libswscale/x86/yuv2rgb_mmx.c | 8 ++++----
>> 1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/libswscale/x86/yuv2rgb_mmx.c b/libswscale/x86/yuv2rgb_mmx.c
>> index 23d4c42..439482b 100644
>> --- a/libswscale/x86/yuv2rgb_mmx.c
>> +++ b/libswscale/x86/yuv2rgb_mmx.c
>> @@ -82,15 +82,15 @@ SwsFunc ff_yuv2rgb_init_mmx(SwsContext *c)
>> if (HAVE_MMX && cpu_flags & AV_CPU_FLAG_MMX) {
>> switch (c->dstFormat) {
>> case PIX_FMT_RGB32:
>> - if (CONFIG_SWSCALE_ALPHA && c->srcFormat ==
>> PIX_FMT_YUVA420P) {
>> -#if HAVE_7REGS
>> + if (c->srcFormat == PIX_FMT_YUVA420P) {
>> +#if HAVE_7REGS && CONFIG_SWSCALE_ALPHA
>> return yuva420_rgb32_MMX;
>> #endif
>> break;
>> } else return yuv420_rgb32_MMX;
>> case PIX_FMT_BGR32:
>> - if (CONFIG_SWSCALE_ALPHA && c->srcFormat ==
>> PIX_FMT_YUVA420P) {
>> -#if HAVE_7REGS
>> + if (c->srcFormat == PIX_FMT_YUVA420P) {
>> +#if HAVE_7REGS && CONFIG_SWSCALE_ALPHA
>> return yuva420_bgr32_MMX;
>> #endif
>> break;
>> --
>
> why the condition above #if is not enough?
I'm not sure if this is a gcc bug or something else, but I've noticed
before that dead symbol elimination does not get rid of function
pointer references. I had the same problem in swscale.c returning
swscale_{opt} function pointers.
Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
