2011/6/6 Måns Rullgård <[email protected]>: > Alex Converse <[email protected]> writes: > >> This allows us to see if the later allcoation fails. >> --- >> libavformat/mov.c | 12 ++++++------ >> 1 files changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/libavformat/mov.c b/libavformat/mov.c >> index 6c3c95c..1f3f691 100644 >> --- a/libavformat/mov.c >> +++ b/libavformat/mov.c >> @@ -390,7 +390,7 @@ static int mov_read_dref(MOVContext *c, AVIOContext *pb, >> MOVAtom atom) >> if (len&1) >> len += 1; >> if (type == 2) { // absolute path >> - av_free(dref->path); >> + av_freep(&dref->path); >> dref->path = av_mallocz(len+1); > > What's the point of setting something to null when it is immediately and > unconditionally overwritten? >
nevermind, I wasn't thinking clearly, withdrawn > -- > Måns Rullgård > [email protected] > _______________________________________________ > libav-devel mailing list > [email protected] > https://lists.libav.org/mailman/listinfo/libav-devel > _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
