On Mon, Jun 06, 2011 at 07:39:24PM +0100, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > > On Mon, Jun 06, 2011 at 05:52:16PM +0100, Mans Rullgard wrote: > >> --- /dev/null > >> +++ b/tests/Makefile > >> @@ -0,0 +1,119 @@ > >> +include $(SRC_PATH_BARE)/tests/fate.mak > >> +include $(SRC_PATH_BARE)/tests/fate2.mak > >> + > >> +include $(SRC_PATH_BARE)/tests/fate/aac.mak > >> +include $(SRC_PATH_BARE)/tests/fate/als.mak > >> +include $(SRC_PATH_BARE)/tests/fate/fft.mak > >> +include $(SRC_PATH_BARE)/tests/fate/h264.mak > >> +include $(SRC_PATH_BARE)/tests/fate/mp3.mak > >> +include $(SRC_PATH_BARE)/tests/fate/vorbis.mak > >> +include $(SRC_PATH_BARE)/tests/fate/vp8.mak > > > > unrelated: > > > > include $(SRC_PATH_BARE)/tests/fate/*.mak > > Bad idea.
Why? Wildcards are perfectly legal in Makefile include statements and all Makefile snippets in that directory should be picked up automatically. > >> +FATE = $(FATE_ACODEC) \ > >> + $(FATE_VCODEC) \ > >> + $(FATE_LAVF) \ > >> + $(FATE_LAVFI) \ > >> + $(FATE_SEEK) \ > > > > extra karma: Maybe you can cut down on that silly amount of whitespace > > while moving the line anyway. > > Does it bother you? Sure. > >> +ifdef SAMPLES > >> +FATE += $(FATE_TESTS) > > > > unrelated: This reminds me that I'd prefer for SAMPLES to be renamed to > > FATE_SAMPLES, just as the environment variable. > > Why? Do you enjoy typing? It should slightly simplify the build system if we could drop one of the two variables. And I don't mind typing a few more letters - I'm quick at hitting M-/. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
