On 06/07/2011 01:57 PM, Ronald S. Bultje wrote: > Hi, > > On Tue, Jun 7, 2011 at 12:50 PM, Justin Ruggles > <[email protected]> wrote: >> --- >> libavcodec/Makefile | 3 +- >> libavcodec/ac3enc.c | 284 >> +------------------------------------------------- >> libavcodec/ac3enc.h | 214 +++++++++++++++++++++++++++++++++++++ >> libavcodec/eac3enc.c | 131 +++++++++++++++++++++++ >> libavcodec/eac3enc.h | 44 ++++++++ >> 5 files changed, 396 insertions(+), 280 deletions(-) >> create mode 100644 libavcodec/ac3enc.h >> create mode 100644 libavcodec/eac3enc.c >> create mode 100644 libavcodec/eac3enc.h > > LGTM. > > Maybe some build guru can correct me, but should eac3enc depend on > ac3enc and only list eac3*.c as its build targets?
I don't think so. In this case it's a little different than for the decoder. For decoding, normal AC-3 is actually also valid E-AC-3, so a compliant E-AC-3 decoder has to support both codecs. For encoding you could have one or the other or both. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
