On Wed, 8 Jun 2011, Etienne Buira wrote:
> On Wed, Jun 08, 2011 at 11:37:59PM +0300, Martin Storsjö wrote:
> > On Wed, 8 Jun 2011, Etienne Buira wrote:
> >
> > > On Wed, Jun 08, 2011 at 10:55:03PM +0300, Martin Storsjö wrote:
> > > > The original commit that this is a cherry-pick of actually
> > > > introduced a memory leak - this only fixes the potential
> > >
> > > What leak? If I trust libavformat/utils.c:avformat_free_context(),
> > > av_opt_free() is called so the hunk you removed is only a small cleanup.
> >
> > If that were the case, it'd be a case of mixing two different things in
> > the same commit - in the original form, it looked like it was related to
> > the change of av_free to av_freep, which it was clearly not.
>
> It was related to use of av_opt_free, which will try to double free if
> not NULLed (and sorry for the obvious & mistake).
I see, that makes sense - then this patch isn't just a safeguard but
actually needed, if we'd add av_opt_free to the ffurl_open/close calls.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
