On Thu, Jun 09, 2011 at 11:55:58AM -0400, Justin Ruggles wrote: > On 06/08/2011 09:45 AM, Diego Biurrun wrote: > > On Wed, Jun 08, 2011 at 03:30:31PM +0200, Diego Biurrun wrote: > >> On Wed, Jun 08, 2011 at 06:08:28AM -0700, Kieran Kunhya wrote: > >>>> "Do the right thing" is not really descriptive, nobody > >>>> would ever consciously make a program "do the wrong thing". > >>> > >>> One would "do the wrong thing" be rejecting a patch which fixes a bug > >>> merely on the basis of a poor commit message. > >> > >> Glad to hear I'm doing the absolute right thing by fixing up the log > >> message myself and pushing the patch then :) > > > > Hmmm, this triggers a strange failure in FATE: > > > > biurrun@passion:~/src/priv/libav $ make fate-eac3-2 V=1 > > TEST eac3-2 > > "/home/biurrun/src/priv/libav"/tests/fate-run.sh fate-eac3-2 > > "/home/biurrun/fate-suite" "" "/home/biurrun/src/priv/libav" 'pcm -i > > /home/biurrun/fate-suite/eac3/csi_miami_stereo_128_spx_small.eac3' 'oneoff' > > '/home/biurrun/fate-suite/eac3/csi_miami_stereo_128_spx_small.pcm' '' '' '' > > /home/biurrun/src/priv/libav/ffmpeg -v 0 -threads 1 -thread_type 3 -i > > /home/biurrun/fate-suite/eac3/csi_miami_stereo_128_spx_small.eac3 -vn -f > > s16le - > > (standard_in) 1: syntax error > > > > make: *** [fate-eac3-2] Error 1 > > > > I have unqueued the patch for now, please figure out with Justin what is > > going wrong there... > > It seems that the fate sample wasn't trimmed on a frame boundary. So the > eac3 score is low and more likely to conflict with other formats. In > this case it conflicts with both mpeg and aac.
This sounds like we should update the sample. If you can do that, I will install the fixed sample in the samples suite. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
