On 06/10/2011 06:31 PM, Ronald S. Bultje wrote: > +#define r_b ((target == PIX_FMT_RGB48LE || target == PIX_FMT_RGB48BE) ? r : > b) > +#define b_r ((target == PIX_FMT_RGB48LE || target == PIX_FMT_RGB48BE) ? b : > r)
Having the r_b and b_r macros inside a separate function is quite confusing to read. I would suggest moving them to before the first function that uses them and undef them after the last function that uses them. That makes it more immediately obvious that the macro is used by several functions. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
