On date Sunday 2011-06-12 15:23:35 -0400, Ronald S. Bultje encoded:
> Hi,
>
> On Sun, Jun 12, 2011 at 2:05 PM, Stefano Sabatini
> <[email protected]> wrote:
> > commit b4af3cf3470a14626e5d2f40ce3c88bfdd0c8561
> > Author: Stefano Sabatini <[email protected]>
> > Date: Sun Jun 5 00:03:59 2011 +0200
> >
> > cmdutils: remove unnecessary OPT_DUMMY implementation
> >
> > The -i INPUT option can be implemented more cleanly by using a
> > function option, which can easily be done now that the
> > parse_arg_function passed to parse_options has a standard signature.
> >
> > which allows imo a cleaner and more robust implementation.
>
> I'm confused. AFAIK, when I committed/OK'ed this, OPT_DUMMY was never
> there, I even recall making a comment that that was suboptimal and
> that whatever the above did was a cleaner way of accomplishing the
> same with less code/clutter. Did someone else commit the original
> implementation, and then the above fixes it to revert back to my
> implementation of it?
Clarification: Libav never had OPT_DUMMY, what I suggested is to
simply change the "i" OptionDef entry (and move upward definition of
opt_input_file() for avoiding a forward declaration), as done in the
patch above (i.e. you don't need the OPT_DUMMY removal hunks).
--
A feature is nothing more than a bug with seniority.
-- Unknown source
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
