Hi,
On Fri, Jun 10, 2011 at 4:13 PM, Anton Khirnov <[email protected]> wrote:
> + if (out_options && ret == AVERROR_OPTION_NOT_FOUND)
> + av_dict_set(out_options, t->key, t->value, 0);
> + else if (ret < 0) {
if (..) {
..
} else ..
Otherwise OK. I know you don't like this two-argument approach but I
do think it's cleaner, because it allows us to discard the second
argument. In fact, You'll see that if out_options is NULL, this code
isn't called and the default handler can be used. We can (ab)use that
in all text-tools such as cmdutils.c/ffprobe.c/etc.
Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
