Justin Ruggles <[email protected]> writes: > On 06/13/2011 05:24 AM, Anton Khirnov wrote: > >> From: Carl Eugen Hoyos <[email protected]> >> >> Signed-off-by: Anton Khirnov <[email protected]> >> --- >> libavformat/wav.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >> >> diff --git a/libavformat/wav.c b/libavformat/wav.c >> index 21374e8..92c9bfc 100644 >> --- a/libavformat/wav.c >> +++ b/libavformat/wav.c >> @@ -52,7 +52,6 @@ static int wav_write_header(AVFormatContext *s) >> if (ff_put_wav_header(pb, s->streams[0]->codec) < 0) { >> av_log(s, AV_LOG_ERROR, "%s codec not supported in WAVE format\n", >> s->streams[0]->codec->codec ? >> s->streams[0]->codec->codec->name : "NONE"); >> - av_free(wav); >> return -1; >> } >> ff_end_tag(pb, fmt); > > ok.
Patch OK, commit message not OK. The free() is *WRONG*, not merely superfluous. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
