On date Tuesday 2011-06-14 00:01:30 +0200, Stefano Sabatini encoded:
> On date Monday 2011-06-13 10:17:04 -0400, Ronald S. Bultje encoded:
> > Hi,
> > 
> > On Mon, Jun 13, 2011 at 5:23 AM, Anton Khirnov <[email protected]> wrote:
> > > From: Michael Niedermayer <[email protected]>
> > >
> > > Signed-off-by: Anton Khirnov <[email protected]>
> > > ---
> > >  libavfilter/vf_scale.c |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c
> > > index 65fe01c..f3f32ab 100644
> > > --- a/libavfilter/vf_scale.c
> > > +++ b/libavfilter/vf_scale.c
> > > @@ -205,6 +205,8 @@ static int config_props(AVFilterLink *outlink)
> > >
> > >     scale->input_is_pal = av_pix_fmt_descriptors[inlink->format].flags & 
> > > PIX_FMT_PAL;
> > >
> > > +    if(scale->sws)
> > > +        sws_freeContext(scale->sws);
> > >     scale->sws = sws_getContext(inlink ->w, inlink ->h, inlink ->format,
> > 
> > The if() isn't necessary, sws_freeContext already does that.
> > 
> 
> > Does this mean config_props() can be repeatedly called without a
> > cleanup by the filtering library? That seems like a bug. Stefano?

Ah and in case you wonder, yes the other sws contexts should be freed
as well, as was done in a separate patch from me.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to