On Sun, 12 Jun 2011 19:33:05 -0400, "Ronald S. Bultje" <[email protected]> wrote: > Hi, > > On Fri, Jun 10, 2011 at 4:13 PM, Anton Khirnov <[email protected]> wrote: > > +static void assert_avoptions(AVDictionary *m) > > +{ > > + AVDictionaryEntry *t; > > + if ((t = av_dict_get(m, "", NULL, AV_DICT_IGNORE_SUFFIX))) { > > + av_log(NULL, AV_LOG_ERROR, "Option %s not found.\n", t->key); > > + ffmpeg_exit(1); > > + } > > +} > > Why this function? If av_opt_set_dict() gets no argument, it warns > automagically. > > > -do_ffmpeg $pcm_ref -ab 128k -ac 2 -ar 44100 -f s16le -i $pcm_src -f wav > > +do_ffmpeg $pcm_ref -ab 128k -channels 2 -sample_rate 44100 -f s16le -i > > $pcm_src -f wav > > I'm uncomfortable with removing old options. Or do they still work? We > need a transition time for them at least. Plus changelog entries etc. >
I'd add a compat layer, but the way all those globals interact is a mystery to me. We should do it though sooner or later, it's not very user-friendly to have -ar for output and -sample_rate for input. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
