Jason Garrett-Glaser <[email protected]> writes: > On Mon, Jun 13, 2011 at 2:42 PM, Ronald S. Bultje <[email protected]> wrote: >> Hi, >> >> On Mon, Jun 13, 2011 at 5:29 PM, Ronald S. Bultje <[email protected]> wrote: >>> On Mon, Jun 13, 2011 at 3:15 PM, Ronald S. Bultje <[email protected]> >>> wrote: >>>> On Mon, Jun 13, 2011 at 2:40 PM, Jason Garrett-Glaser <[email protected]> >>>> wrote: >>>>> ... and an update to fix PCM in 4:0:0 mode. >>>> >>>> Brief: LGTM. >>>> >>>> Longer: next time please do split the >>>> "extract-code-into-its-own-function", it does make patches easier to >>>> review, this is ... huge. But other than that the patch looks good, so >>>> let's not block it on cosmetics... Push it. >>> >>> Fix for PPC attached. Appears to pass fate also now. >> >> Fix for x86-64 attached also. >> >> Ronald > > Try 2: fixed version pushed. > > Note: I disabled the one ARM function that needs to be changed so Mans > can write the changes optimally later.
Thank you. > This will probably have a temporary small impact on performance (a few > percent), but I'd rather the function be written well than hackily. It is also better than failing. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
