On Tue, Jun 14, 2011 at 12:33:54PM +0100, Måns Rullgård wrote:
> Diego Biurrun <[email protected]> writes:
> 
> > On Tue, Jun 14, 2011 at 11:01:32AM +0100, Mans Rullgard wrote:
> >> Signed-off-by: Mans Rullgard <[email protected]>
> >> ---
> >>  Makefile   |    5 +++++
> >>  common.mak |    5 -----
> >>  2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > I think the patch is OK, but I'm not sure why you are moving the
> > directives, so I'd appreciate a short explanation in the log
> > message.
> 
> There's no point having things in a multiply included file but guarded
> such that they are only seen once.

Patch OK, ideally with that explanation added to the log message.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to