Hi, On Tue, Jun 14, 2011 at 6:57 AM, Anton Khirnov <[email protected]> wrote: > This way the caller can pass all the options in one nice package. > --- > libavutil/opt.c | 22 ++++++++++++++++++++++ > libavutil/opt.h | 13 +++++++++++++ > 2 files changed, 35 insertions(+), 0 deletions(-) [..] > +/* > + * Set the options contained in the dictionary to obj. > + * > + * @param obj a struct whose first element is a pointer to AVClass
> + * @param options options to process. Will be replaced with an AVDictionary > + * containing all options not found in obj. OK fine we'll go with your way. Patch OK, _only if_ you've fixed the documentation to be clear: - The dictionary will be invalidated inside the function and should not be used after calling this function. - Perhaps reference av_dict_copy(). - The returned AVDictionary should be free'ed with av_dict_free() by the caller. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
