On 6/14/11 3:39 PM, Diego Biurrun wrote:
On Tue, Jun 14, 2011 at 02:37:29PM -0500, Luca Barbato wrote:
On 6/14/11 2:35 PM, Ronald S. Bultje wrote:
---
ffmpeg.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -684,6 +684,7 @@ static int read_ffserver_streams(AVFormatContext *s, const
char *filename)
// FIXME: a more elegant solution is needed
st = av_mallocz(sizeof(AVStream));
memcpy(st, ic->streams[i], sizeof(AVStream));
+ st->info = NULL;
st->codec = avcodec_alloc_context();
if (!st->codec) {
print_error(filename, AVERROR(ENOMEM));
ok
No, not OK - the log message completely sucks.
Since I'd like to have more productive comments, the next "completely
sucks" message could please be accompanied by a patch or a more proper
commit message?
e.g. :
I feel the message maybe a little too terse so I'd suggest to add
"The ffserver codepath wasn't updated to take account of the AVStream
info field introduction"
Or something along the line.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
