Hi, On Tue, Jun 14, 2011 at 2:20 PM, Justin Ruggles <[email protected]> wrote: > This fixes a segfault when using the C version of ac3dsp.float_to_fixed24(). > --- > On 06/12/2011 04:26 PM, Ronald S. Bultje wrote: > >> Hi, >> >> On Sat, Jun 11, 2011 at 12:04 PM, Justin Ruggles >> <[email protected]> wrote: >>> >>> This fixes a segfault with assembly optimizations disabled. >>> --- >>> libavcodec/ac3enc.c | 18 +++++++++++------- >>> 1 files changed, 11 insertions(+), 7 deletions(-) >> >> I'm assuming that the "padded" entries at start/end are not only >> allocated to zero (which they are), but also that it is not possible >> that they get "unzeroed" somehow in a previous iteration of this code >> (e.g. previous frame), and that we then assume them to be zero even >> when they're not, and therefore get invalid results? >> >> If that's all taken care of, then patch OK. > > well, it's not taken care of but the invalid results aren't used. here is a > revised patch that's a bit nicer and also takes care of all that. > > libavcodec/ac3enc_template.c | 24 +++++++++++++----------- > 1 files changed, 13 insertions(+), 11 deletions(-)
Looks allright to me. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
