On Wed, 15 Jun 2011 14:01:29 -0400, Justin Ruggles <[email protected]> 
wrote:
> On 06/15/2011 01:12 PM, Anton Khirnov wrote:
> 
> > 
> > On Wed, 15 Jun 2011 13:06:53 -0400, Justin Ruggles 
> > <[email protected]> wrote:
> >> On 06/15/2011 12:20 PM, Anton Khirnov wrote:
> >>
> >>>      if (audio_stream_copy) {
> >>>          st->stream_copy = 1;
> >>> -        audio_enc->channels = audio_channels;
> >>> +        if (audio_channels)
> >>> +            audio_enc->channels = audio_channels;
> >>
> >>
> >> Should we be doing this for stream copy?  This will be overridden later
> >> anyway to use the value from the corresponding input.
> > 
> > Where?
> 
> 
> transcode():
> 
> if (ost->st->stream_copy) {
>     [...]
>     switch(codec->codec_type) {
>     case AVMEDIA_TYPE_AUDIO:
>         [...]
>         codec->channels = icodec->channels;
>         [...]
> 

Oh. That probably applies to the first patch too.

--
Anton Khirnov
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to