On Tue, Jun 14, 2011 at 10:17:45AM +0100, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > > On Tue, Jun 07, 2011 at 10:19:23AM +0100, Mans Rullgard wrote: > >> > >> --- a/Makefile > >> +++ b/Makefile > >> @@ -100,28 +95,6 @@ version.h .version: > >> > >> -doc/%.1: TAG = MAN > >> -doc/%.1: doc/%.pod > >> - $(M)pod2man --section=1 --center=" " --release=" " $< > $@ > >> - > >> ifdef PROGS > >> install: install-progs install-data > >> endif > >> @@ -141,11 +114,7 @@ install-data: $(DATA_FILES) > >> $(Q)mkdir -p "$(DATADIR)" > >> $(INSTALL) -m 644 $(DATA_FILES) "$(DATADIR)" > >> > >> -install-man: $(MANPAGES) > >> - $(Q)mkdir -p "$(MANDIR)/man1" > >> - $(INSTALL) -m 644 $(MANPAGES) "$(MANDIR)/man1" > >> - > >> -uninstall: uninstall-libs uninstall-headers uninstall-progs > >> uninstall-data uninstall-man > >> +uninstall: uninstall-libs uninstall-headers uninstall-progs uninstall-data > > > > The following line is erroneously left behind I think: > > > > install-progs-$(CONFIG_DOC): install-man > > Matter of debate. That line is arguably more related to the programs > than to the documentation.
I think it makes more sense to have it in the subdirectory Makefile, the install-man target it refers to has been moved there as well. Plus, if you want to modularize the Makefiles, moving all optional parts to the subdirectory Makefiles makes sense. The ffserver regression test is also moved to the subdirectory Makefile even though you can argue whether or not it is more related to ffserver or the tests. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
