On 06/20/2011 11:09 AM, Justin Ruggles wrote: > On 06/20/2011 01:18 AM, Nathan Caldwell wrote: > >> On Sun, Jun 19, 2011 at 10:29 PM, Nathan Caldwell <[email protected]> wrote: >>> @@ -104,6 +121,16 @@ typedef struct FFPsyModel { >>> */ >>> void (*analyze)(FFPsyContext *ctx, int channel, const float *coeffs, >>> const FFPsyWindowInfo *wi); >>> >>> + /** >>> + * Perform psychoacoustic analysis and set band info (threshold, >>> energy) for a group of channels. >>> + * >>> + * @param ctx model context >>> + * @param channel channel number of the first channel in the group to >>> perform analysis on >>> + * @param coeffs array of pointers to the transformed coefficients >>> + * @param wi window information for all channels >> >> I got this wrong in the next patch. >> >> Should the wi array passed should be for all channels (as stated >> here), or starting at the first channel of the group (as implemented >> later)? The latter seems to simpler things, as you can index with 0 >> and 1 instead of channel + 0/1. > > > Well, if you have the channel map information, with the channel index > you can know if you're dealing with, for example, a left/right front > pair or left/right surround pair, which might affect processing. That's > the only reason I can think of for keeping it. If that doesn't make > sense for AAC then the 2nd option sounds easier to work with.
Oh, nevermind. I misunderstood. You don't need window information for the other channels. But still, you might want to know which channels you're dealing with. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
