On Mon, Jun 20, 2011 at 10:34:04PM +0200, Vitor Sessak wrote: > On Mon, Jun 20, 2011 at 9:37 PM, Diego Biurrun <[email protected]> wrote: > > On Mon, Jun 20, 2011 at 08:46:26PM +0200, Vitor Sessak wrote: > >> Cherry picked from FFmpeg. 10l for me. > >> > >> From 44d1b4088f2959912a27ffbffc5884db1b35a645 Mon Sep 17 00:00:00 2001 > >> From: Michael Niedermayer <[email protected]> > >> Date: Sat, 18 Jun 2011 02:44:17 +0200 > >> Subject: [PATCH] qdm2: Fix alignment of local array. > >> > >> Fixes ticket270 > > > > Another 10l for blindly cherry-picking changes without adapting > > the log message. > > As attached? > -Vitor, still learning GIT ethiquette...
No. And this is not related to git *at all*. WTF is ticket270? There are multiple problems: 1) Libav does not use that bug tracker. 2) Bug tracker references are fine if they appear *in addition* to a problem description. A log message must make sense *standalone*, without reference to external sources. You might as well write "This commit fixes a random bug, for details see a file I keep hidden and encrypted on a USB stick I carry around my neck". What you should do is go look at ticket270 and quickly summarize whatever it is about in the log message. After that you could add "for extra gory details see ticket270". Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
