On 6/20/11 4:45 PM, Diego Biurrun wrote:
Would some log message writing guidelines in the developer documentation
help?
It is already present:
"Log messages should be concise but descriptive. Explain why you made a
change, what you did will be obvious from the changes themselves most of
the time.
Saying just "bug fix" or "10l" is bad. Remember that people of varying
skill levels look at and educate themselves while reading through your
code. Don't include filenames in log messages, Git provides that
information.
Possibly make the commit message have a terse, descriptive first line,
an empty line and then a full description. The first line will be used
to name the patch by git format-patch.
Do we just need more discipline? Closer scrutiny during review?
We should just pay more attention now and then. The commit messages
aren't that bad, just we should try to fill the 2-3 lines of description
harder.
lu
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
