Diego Biurrun <[email protected]> writes:

> On Wed, Jun 22, 2011 at 11:14:52PM +0100, Mans Rullgard wrote:
>> 
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -126,8 +124,8 @@ tools/%.o: tools/%.c
>>  
>> -VERSION_SH  = $(SRC_PATH_BARE)/version.sh
>> -GIT_LOG     = $(SRC_PATH_BARE)/.git/logs/HEAD
>> +VERSION_SH  = $(SRC_PATH)/version.sh
>> +GIT_LOG     = $(SRC_PATH)/.git/logs/HEAD
>>  
>>  .version: $(wildcard $(GIT_LOG)) $(VERSION_SH) config.mak
>
> unrelated: The GIT_LOG variable is only used once, so it could
> be eliminated.

That would make the next line rather long and hard to read.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to