On 06/27/2011 01:28 PM, Måns Rullgård wrote: > Justin Ruggles <[email protected]> writes: > >> This avoids using function pointers for quite a few small functions, most of >> which just call DSP functions. >> --- >> libavcodec/ac3enc.c | 82 >> +++++------------------------------------- >> libavcodec/ac3enc.h | 58 ++++++++++------------------- >> libavcodec/ac3enc_fixed.c | 11 +++--- >> libavcodec/ac3enc_float.c | 19 +++++++--- >> libavcodec/ac3enc_template.c | 78 +++++++++++++++++++++++++++++++++++---- >> libavcodec/eac3enc.c | 2 +- >> 6 files changed, 119 insertions(+), 131 deletions(-) >> >> diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c >> index 3fbbbd0..44dfce8 100644 >> --- a/libavcodec/ac3enc.c >> +++ b/libavcodec/ac3enc.c >> @@ -177,7 +177,7 @@ static const int8_t ac3_coupling_start_tab[6][3][19] = { >> * Adjust the frame size to make the average bit rate match the target bit >> rate. >> * This is only needed for 11025, 22050, and 44100 sample rates or any >> E-AC-3. >> */ >> -static void adjust_frame_size(AC3EncodeContext *s) >> +void ff_ac3_adjust_frame_size(AC3EncodeContext *s) > > This seems to turn a few previously inlined functions into proper > calls. I doubt it makes a difference though.
No, I don't think it makes much difference. Most of the functions in ac3enc.c are still wrapped together into the shared functions, e.g. process_exponents() and output_frame(), and can be inlined there. -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
