Diego Biurrun <[email protected]> writes: > On Tue, Jun 28, 2011 at 06:46:05PM +0100, Mans Rullgard wrote: >> Signed-off-by: Mans Rullgard <[email protected]> >> --- >> Makefile | 7 ++++++- >> common.mak | 6 ++++++ >> configure | 31 +++++-------------------------- >> doc/Makefile | 3 +++ >> 4 files changed, 20 insertions(+), 27 deletions(-) > > OK > >> --- a/Makefile >> +++ b/Makefile >> @@ -185,6 +187,9 @@ check: test checkheaders >> >> +$(sort $(OBJDIRS)): >> + $(Q)mkdir -p $@ >> --- a/common.mak >> +++ b/common.mak >> @@ -34,6 +34,12 @@ $(HOSTOBJS): %.o: %.c >> >> +$(OBJS): | $(dir $(OBJS)) >> +$(HOSTOBJS): | $(dir $(HOSTOBJS)) >> +$(TESTOBJS): | $(dir $(TESTOBJS)) >> + >> +OBJDIRS := $(OBJDIRS) $(dir $(OBJS) $(HOSTOBJS) $(TESTOBJS)) > > I'd consider it more natural to do the sort here and not clutter > the rule with it, but I'll leave that up to you.
I thought at first more places would add potential duplicates. It turns out that wasn't the case, so the sort could be moved. In that case, care must be taken if adding more entries later. It seems more robust to do the duplicate removal where it is required, i.e. at the mkdir rule. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
