On Wed, Jun 29, 2011 at 09:32:26AM +0100, Måns Rullgård wrote:
> Diego Biurrun <[email protected]> writes:
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -41,16 +41,8 @@ tests/seek_test$(EXESUF): tests/seek_test.o 
> > $(FF_DEP_LIBS)
> >
> > -include $(SRC_PATH)/tests/fate.mak
> > -include $(SRC_PATH)/tests/fate2.mak
> > -
> > -include $(SRC_PATH)/tests/fate/aac.mak
> > -include $(SRC_PATH)/tests/fate/als.mak
> > -include $(SRC_PATH)/tests/fate/fft.mak
> > -include $(SRC_PATH)/tests/fate/h264.mak
> > -include $(SRC_PATH)/tests/fate/mp3.mak
> > -include $(SRC_PATH)/tests/fate/vorbis.mak
> > -include $(SRC_PATH)/tests/fate/vp8.mak
> > +include $(SRC_PATH)/tests/*.mak
> > +include $(SRC_PATH)/tests/fate/*.mak
> 
> Still rejected for the same reasons already explained.

IIUC you are afraid that some file matching the pattern might
accidentally end up in one of those directories.  I doubt that
such a situation can really arise accidentally.

If another .mak file is added to tests/fate/, then it's meant to
be read by Make.  With a wildcard pattern no extra registration
is necessary, which makes the system more usable.

Plus, it saves a few lines of code.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to