On Wed, Jun 29, 2011 at 02:38:23PM -0700, Ronald S. Bultje wrote: > > On Wed, Jun 29, 2011 at 2:35 PM, Diego Biurrun <[email protected]> wrote: > > On Wed, Jun 29, 2011 at 02:13:20PM -0700, Ronald S. Bultje wrote: > >> > >> --- a/libavformat/matroskadec.c > >> +++ b/libavformat/matroskadec.c > >> @@ -1879,11 +1879,13 @@ static int > >> matroska_parse_cluster(MatroskaDemuxContext *matroska) > >> static int matroska_read_packet(AVFormatContext *s, AVPacket *pkt) > >> { > >> MatroskaDemuxContext *matroska = s->priv_data; > >> + int ret; > >> > >> while (matroska_deliver_packet(matroska, pkt)) { > >> if (matroska->done) > >> return AVERROR_EOF; > >> - matroska_parse_cluster(matroska); > >> + ret = matroska_parse_cluster(matroska); > >> + if (ret) return ret; > >> } > >> > >> return 0; > > > > Why not just 'return ret;'? > > There's a while() there.
Doh - I'm blind... Patch OK, but please break the line; statements on the same line as the if are ugly and two lines above it is formatted differently. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
