On Thu, Jun 30, 2011 at 10:49:49AM +0100, Mans Rullgard wrote:
> Signed-off-by: Mans Rullgard <[email protected]>
OK
> --- a/libavutil/aes.c
> +++ b/libavutil/aes.c
> @@ -54,18 +54,34 @@ static uint32_t enc_multbl[4][256];
> +
> + s0[0].u8[ 0] = box[s0[1].u8[0 ]];
> + s0[0].u8[ 4] = box[s0[1].u8[4 ]];
> + s0[0].u8[ 8] = box[s0[1].u8[8 ]];
> + s0[0].u8[12] = box[s0[1].u8[12]];
> + s1[0].u8[ 3] = box[s1[1].u8[7 ]];
> + s1[0].u8[ 7] = box[s1[1].u8[11]];
> + s1[0].u8[11] = box[s1[1].u8[15]];
> + s1[0].u8[15] = box[s1[1].u8[3 ]];
> + s0[0].u8[ 2] = box[s0[1].u8[10]];
> + s0[0].u8[10] = box[s0[1].u8[2 ]];
> + s0[0].u8[ 6] = box[s0[1].u8[14]];
> + s0[0].u8[14] = box[s0[1].u8[6 ]];
> + s3[0].u8[ 1] = box[s3[1].u8[13]];
> + s3[0].u8[13] = box[s3[1].u8[9 ]];
> + s3[0].u8[ 9] = box[s3[1].u8[5 ]];
> + s3[0].u8[ 5] = box[s3[1].u8[1 ]];
This would be slightly more readable with the indexes consistently
right-aligned.
> @@ -85,116 +101,134 @@ static inline void mix(av_aes_block state[2], uint32_t
> multbl[][256], int s1, in
>
> -
> if(!enc_multbl[FF_ARRAY_ELEMS(enc_multbl)-1][FF_ARRAY_ELEMS(enc_multbl[0])-1]){
> + if
> (!enc_multbl[FF_ARRAY_ELEMS(enc_multbl)-1][FF_ARRAY_ELEMS(enc_multbl[0])-1]) {
nit: space around '-'
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
