On Thu, Jun 30, 2011 at 03:12:28PM +0200, Stefano Sabatini wrote: > On date Thursday 2011-06-30 14:31:57 +0200, Diego Biurrun encoded: > > On Thu, Jun 30, 2011 at 02:12:46PM +0200, Stefano Sabatini wrote: > > > On date Thursday 2011-06-30 13:37:00 +0200, Diego Biurrun encoded: > [...] > > > > > This is still busted on non-x86. It needs a complete rewrite. > > > > > > > > As an alternative, I could remove it - I'll send a patch for that. > > > > > > Eh? What's the point of removing everything which "looks broken"?, tests > > > are > > > useful both as API usage example and for testing the code (e.g. when > > > debugging). > > > I suggest you look at that program first before flaming :) > > Check the attached patch.
Mans was faster than you. > > That said, FFmpeg history has shown that old broken code never gets > > fixed anyway, it's just left to rot and rot and rot ... > > There are notable exceptions, removing old broken/unused code should > be done on a case-by-case basis and only if there is a real need for > it. Which notable exceptions? Unused and broken code should be deleted, it just clutters the codebase for no gain at all. We use revision control for many reasons. One is that it becomes easy to resurrect old code - problem solved. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
