On Sun, Jul 03, 2011 at 09:44:04AM -0700, Ronald S. Bultje wrote:
> 
> On Sun, Jul 3, 2011 at 7:42 AM, Diego Biurrun <[email protected]> wrote:
> > --- a/libavcodec/h264idct_template.c
> > +++ b/libavcodec/h264idct_template.c
> > @@ -237,7 +237,6 @@ void FUNCC(ff_h264_idct_add8)(uint8_t **dest, const int 
> > *block_offset, DCTELEM *
> >  }
> >  /**
> >  * IDCT transforms the 16 dc values and dequantizes them.
> > - * @param qp quantization parameter
> >  */
> >  void FUNCC(ff_h264_luma_dc_dequant_idct)(DCTELEM *_output, DCTELEM 
> > *_input, int qmul){
> 
> s/qp/qmul/?

quite likely - patch coming up ..

> >  * @param inv_table the yuv2rgb coefficients, normally ff_yuv2rgb_coeffs[x]
> > - * @param fullRange if 1 then the luma range is 0..255 if 0 it is 16..235
> >  * @return -1 if not supported
> >  */
> >  int sws_setColorspaceDetails(struct SwsContext *c, const int inv_table[4],
> 
> SWS_CS_* for src/dstRange, that can also be made an enum.

patches welcome :)

Seriously, I'm not following what you want done here...

> Don't remove stuff if it's clearly just outdated.

It seems you have stared too long at swscale to notice what is obvious
and what is not. :)

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to