On Sun, Jul 03, 2011 at 11:18:55PM +0300, Martin Storsjö wrote: > On Sun, 3 Jul 2011, Diego Biurrun wrote: > > > On Sun, Jul 03, 2011 at 10:58:36PM +0300, Martin Storsjö wrote: > > > On Sun, 3 Jul 2011, Diego Biurrun wrote: > > > > > > > Do not use Doxygen for comments that apply to specific implementation > > > > details; > > > > merge some duplicated Doxygen comment blocks; delete inappropriate ones. > > > > --- a/libavformat/rtsp.c > > > > +++ b/libavformat/rtsp.c > > > > @@ -428,11 +428,6 @@ static void sdp_parse_line(AVFormatContext *s, > > > > SDPParseState *s1, > > > > > > > > -/** > > > > - * Parse the sdp description and allocate the rtp streams and the > > > > - * pollfd array used for udp ones. > > > > - */ > > > > - > > > > > > Why is this removed? If not appropriate as a doxy comment, I'd rather > > > keep > > > it as a normal comment. > > > > Because in rtsp.h we have practically the same description already: > > > > /** > > * Parse a SDP description of streams by populating an RTSPState struct > > * within the AVFormatContext. > > */ > > That one doesn't say anything about the pollfd array, and populating the > RTSPState struct and allocating the RTP streams isn't exactly the same > thing.
Pushing the merged version you just approved on IRC... Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
