Jason Garrett-Glaser <[email protected]> writes: > 2011/7/4 Måns Rullgård <[email protected]>: >> "Jason Garrett-Glaser " <[email protected]> writes: >> >>> Module: libav >>> Branch: master >>> Commit: 4320a309ce10a7eec93aef239a0776a33b1a5a34 >>> >>> Author: Jason Garrett-Glaser <[email protected]> >>> Committer: Jason Garrett-Glaser <[email protected]> >>> Date: Mon Jun 27 13:07:26 2011 -0700 >>> >>> H.264: make filter_mb_fast support the case of unavailable top mb >>> >>> Significantly faster deblocking in streams with lots of slices. >>> >>> --- >>> >>> libavcodec/h264_loopfilter.c | 42 >>> ++++++++++++++++++++++++++++-------------- >>> 1 files changed, 28 insertions(+), 14 deletions(-) >> >> This seems to have introduced some invalid reads per >> http://fate.libav.org/x86_32-linux-gcc-valgrind/20110704043908 > > The valgrind log seems to suggest that qp0 = > s->current_picture.qscale_table[mb_xy-1]; also causes an invalid read. > This is interesting, as this line executed when we were on the left > edge -- even before my patch.
Valgrind is only able to catch it on the top row though. > Does qscale_table not have edge padding? Apparently not. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
