Diego Biurrun <[email protected]> writes: > On Sun, Jul 03, 2011 at 06:45:12PM +0100, Måns Rullgård wrote: >> Diego Biurrun <[email protected]> writes: >> >> > --- a/version.sh >> > +++ b/version.sh >> > @@ -22,5 +22,6 @@ OLD_REVISION=$(cat version.h 2> /dev/null) >> > >> > # Update version.h only on revision changes to avoid spurious rebuilds >> > if test "$NEW_REVISION" != "$OLD_REVISION"; then >> > - echo "$NEW_REVISION" > "$2" >> > + echo "/* Automatically generated by $0 - do not modify! */" > "$2" >> > + echo "$NEW_REVISION" >> "$2" >> > fi >> >> Why? > > It seemed prudent to add a quick warning - it clearly cannot hurt. > We have other version.h files that are not generated after all.
Do you realise that your patch makes it write the file every time, forcing needless rebuilds? I don't want to spend time on a proper solution to this non-problem of yours. Just leave it. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
