On Tue, Jul 12, 2011 at 11:02:45AM -0700, Ronald S. Bultje wrote: > On Tue, Jul 12, 2011 at 10:54 AM, Diego Biurrun <[email protected]> wrote: > > On Tue, Jul 12, 2011 at 10:42:58AM -0700, Ronald S. Bultje wrote: > >> On Tue, Jul 12, 2011 at 10:39 AM, Diego Biurrun <[email protected]> wrote: > >> > > >> > ... since now 'make checkheaders' is broken: > >> > > >> > biurrun@passion:~/src/libav $ make checkheaders > >> > CC libavcodec/h264_mvpred.ho > >> > In file included from libavcodec/h264_mvpred.h:33:0: > >> > libavcodec/h264.h: In function ‘decode_mb_skip’: > >> > libavcodec/h264.h:1334:9: error: implicit declaration of function > >> > ‘pred_pskip_motion’ [-Werror=implicit-function-declaration] > >> > libavcodec/h264_mvpred.h: At top level: > >> > libavcodec/h264_mvpred.h:235:30: warning: conflicting types for > >> > ‘pred_pskip_motion’ [enabled by default] > >> > libavcodec/h264_mvpred.h:235:30: error: static declaration of > >> > ‘pred_pskip_motion’ follows non-static declaration > >> > libavcodec/h264.h:1334:9: note: previous implicit declaration of > >> > ‘pred_pskip_motion’ was here > >> > cc1: some warnings being treated as errors > >> > > >> > make: *** [libavcodec/h264_mvpred.ho] Error 1 > >> > >> Don't include h264_mvpred.h directly, instead include h264.h? > > > > Umm, it is h264_mvpred.h itself that is failing to compile since it has > > circular dependencies with h264.h. > > > > A possible solution would be to move decode_mb_skip() to another header. > > Do you have a suitable suggestion? > > Sounds good to me.
Great - and now where do we put decode_mb_skip()? Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
