On Sat, 16 Jul 2011 22:46:32 -0700, "Ronald S. Bultje" <[email protected]> wrote: > Hi, > > On Sat, Jul 16, 2011 at 2:08 PM, Stefano Sabatini > <[email protected]> wrote: > > Also remove now unused variable. > > --- > > doc/ffplay.texi | 3 ++- > > ffplay.c | 6 +++--- > > 2 files changed, 5 insertions(+), 4 deletions(-) > [..] > > static int opt_frame_pix_fmt(const char *opt, const char *arg) > > { > > - frame_pix_fmt = av_get_pix_fmt(arg); > > - return 0; > > + av_log(NULL, AV_LOG_ERROR, > > + "Option '%s' has been removed, use private format options > > instead\n"); > > + return AVERROR(EINVAL); > > } > > I don't like this. I've said it before, I want to keep application > compatibility for a while to assist users that are upgrading. We do > the same for API, and it's not very hard. Putting it under a proper > FF_API_* automates removing it in 1-2 ABI bumps. >
First, ffplay is a toy/testing tool, not a real player. I wouldn't bother with compatibility for it. Second, for ffmpeg it makes sense to keep the old option names, so e.g. -ar can be used for both input and output. But ffplay has no output, so this argument doesn't apply. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
