On date Saturday 2011-07-16 17:15:27 +0200, Stefano Sabatini encoded: > On date Saturday 2011-07-16 17:00:59 +0200, Diego Biurrun encoded: > > On Sat, Jul 16, 2011 at 10:25:58AM +0200, Stefano Sabatini wrote: > > > > > > --- a/libavutil/fifo.h > > > +++ b/libavutil/fifo.h > > > @@ -106,11 +107,34 @@ int av_fifo_realloc2(AVFifoBuffer *f, unsigned int > > > size); > > > > > > +/** > > > + * Return a pointer to the data stored in a FIFO buffer at a certain > > > offset. > > > + * The FIFO buffer is not modified. > > > + * > > > + * @param f pointer to the FIFO buffer to peek at, must be non-NULL > > > > So every caller must check for NULL? > > Yes, this is consistent with the rest of the av_fifo_* API, and most > part of libav*, so I don't know if it is a good idea to add a NULL > check here. > > > > + * @param offs an offset in bytes, its absolute value must be less > > > + * than the used buffer size or the returned pointer will point > > > + * outside to the buffer data > > > > How would the caller know the used buffer size? > > Added a note about av_fifo_size(). > > > Vertical alignment would help make this more readable. > > Updated.
> From d5b9a012308a766de5ef27ec1c7f4a431bd50f13 Mon Sep 17 00:00:00 2001 > From: Stefano Sabatini <[email protected]> > Date: Wed, 29 Jun 2011 17:30:23 +0200 > Subject: [PATCH] fifo: add av_fifo_peek2(), and deprecate av_fifo_peek() > > The new function provides a more generic interface than av_fifo_peek() > for peeking at a FIFO buffer data. Ping. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
