Hi, On Mon, Aug 1, 2011 at 4:58 PM, Luca Barbato <[email protected]> wrote: > On 8/1/11 10:49 PM, Ronald S. Bultje wrote: >> >> Hi, >> >> On Mon, Aug 1, 2011 at 8:49 AM, Luca Barbato<[email protected]> wrote: >>> >>> + /** >>> + * Signal if the current packet is a keyframe (AV_PKT_FLAG_KEY) or >>> + * if the packet is incomplete/corrupted (AV_PKT_FLAG_CORRUPT) >>> + */ >>> int flags; >>> /** >>> * Additional packet data that can be provided by the container. >>> @@ -832,6 +836,7 @@ typedef struct AVPacket { >>> int64_t convergence_duration; >>> } AVPacket; >>> #define AV_PKT_FLAG_KEY 0x0001 >>> +#define AV_PKT_FLAG_CORRUPT 0x0002 >> >> Please add the documentation with the individual flags, not on the >> top. The "int flags" field should just say "a combination of >> AV_PKT_FLAG values". > > I tersely documented those two values, later we might try to improve the > documentation a little more. > > If there aren't more comments I'd push the whole set.
That's not what I meant. The documentation is wrongly placed. It shouldn't be: /** Bla bla AV_PKT_FLAG_this this bla * AV_PKT_FLAG_that bla etc */ int flags; [..] #define AV_PKT_FLAG_this #define AV_PKT_FLAG_that --- it should instead be: /** These are AV_PKT_FLAG_* values */ int flags; [..] #define AV_PKT_FLAG_this ///< a this flag #define AV_PKT_FLAG_that ///< a that flag Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
