Hi,

On Tue, Aug 9, 2011 at 2:20 AM, Kostya Shishkov
<[email protected]> wrote:
> ---
>  libavcodec/rv34.c        |  186 
> ++++++++++++++++++++++++++++++++++++++++------
>  libavcodec/rv34.h        |    6 ++
>  libavcodec/rv34dsp.h     |    6 ++
>  libavcodec/rv40dsp.c     |   20 +++++
>  tests/ref/fate/real-rv40 |  186 
> +++++++++++++++++++++++-----------------------
>  5 files changed, 288 insertions(+), 116 deletions(-)

Nice work! Does this make biweight bitexact? Please remove this task
from the multimedia wiki while you're at it. ;-).

Implementation suggestions (let's call these RFCs, I want to see what
you think of them):
- right now you do 2 complete rounds of MC on each of Y/U/V plane and
then the biweight for each plane. What about interleaving these so
that data can stay in cache? Might make performance somewhat better.
- please document what fraction weight1/2 are in (i.e. both are 14bits
fractional)
- can rv34_mc_rv4_b and rv34_mc share any code (in source)?

Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to