Anton Khirnov <[email protected]> writes:

> On Thu, 01 Sep 2011 14:38:34 +0100, Måns Rullgård <[email protected]> wrote:
>> Anton Khirnov <[email protected]> writes:
>> 
>> > On Thu, 01 Sep 2011 12:05:08 +0100, Måns Rullgård <[email protected]> wrote:
>> >> Anton Khirnov <[email protected]> writes:
>> >> 
>> >> > On Thu, 01 Sep 2011 11:24:21 +0100, Måns Rullgård <[email protected]> 
>> >> > wrote:
>> >> >> Anton Khirnov <[email protected]> writes:
>> >> >> 
>> >> >> > This will be useful in the following commit.
>> >> >> > ---
>> >> >> >  cmdutils.c |   12 +++++++-----
>> >> >> >  cmdutils.h |    5 +----
>> >> >> >  2 files changed, 8 insertions(+), 9 deletions(-)
>> >> >> 
>> >> >> All those casts are ugly.
>> >> >
>> >> > What do you suggest?
>> >> 
>> >> Leave the union.
>> >> 
>> >
>> > How should i do the following commit then?
>> 
>> Can you please explain why you can't keep the union?
>> 
>
> Because in the following commit this function will write into provided
> struct + offset
> I don't see how to do that without casts.

Right, then I guess it's OK.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to