Luca Barbato <[email protected]> writes:

> On 9/10/11 8:05 AM, Måns Rullgård wrote:
>> Luca Barbato<[email protected]>  writes:
>>
>>> On 8/26/11 3:33 AM, Måns Rullgård wrote:
>>>> "Ronald S. Bultje"<[email protected]>   writes:
>>>>
>>>>> From: "Ronald S. Bultje"<[email protected]>
>>>>>
>>>>>    From 52.503s (~40fps) to 27.973sec (~80fps) decoding of 480p sintel
>>>>> trailer, i.e. a ~2x speedup overall, on a Nexus S.
>>>>
>>>> [...]
>>>>
>>>>> --- a/libavcodec/arm/asm.S
>>>>> +++ b/libavcodec/arm/asm.S
>>>>> @@ -97,6 +97,12 @@ T       add             \rn, \rn, \rm
>>>>>    T       ldr             \rt, [\rn]
>>>>>    .endm
>>>>>
>>>>> +.macro  ldr_dpren       rt,  rn,  rm:vararg
>>>>> +A       ldr             \rt, [\rn, -\rm]
>>>>> +T       sub             \rt, \rn, \rm
>>>>> +T       ldr             \rt, [\rt]
>>>>> +.endm
>>>>> +
>>>>>    .macro  ldr_post        rt,  rn,  rm:vararg
>>>>>    A       ldr             \rt, [\rn], \rm
>>>>>    T       ldr             \rt, [\rn]
>>>>> @@ -133,6 +139,12 @@ T       ldrh            \rt, [\rn]
>>>>>    T       add             \rn, \rn, \rm
>>>>>    .endm
>>>>>
>>>>> +.macro  ldrb_post       rt,  rn,  rm
>>>>> +A       ldrb            \rt, [\rn], \rm
>>>>> +T       ldrb            \rt, [\rn]
>>>>> +T       add             \rn, \rn, \rm
>>>>> +.endm
>>>>
>>>> Those macro names are very badly chosen.
>>>
>>> ldrb_post seems in line with ldr_post. ldr_dpren named as ldr_dpre
>>> seems equivalent to the other macros using sub. Which names you have
>>> in mind?
>>
>> I'm still trying to figure what "dpren" is supposed to denote.
>
> I think ldr_dpre is the name. it follows the naming used for ldrh_dpre
>
> is that ok?

No, those macros do not do the same thing.

>> The TRMs on http://infocenter.arm.com/ have scheduling information.  As
>> long as you refuse to read the fine documentation, you will not be able
>> to write good code.
>
> I guess that could go as in in the FAQ =)

I expect any serious developer to be capable of locating official
documentation himself.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to