On Tue, 20 Sep 2011 08:18:24 +0200, David Goldwich <[email protected]> wrote: > From 4666e1916daa0ba09ac63b2d293eb8e21a25cc99 Mon Sep 17 00:00:00 2001 > From: David Goldwich <[email protected]> > Date: Sun, 18 Sep 2011 18:04:34 +0200 > Subject: [PATCH] id3v2: add support for non-text and GEOB type tag frames > > This extends the ID3v2 parser to allow for reading of non-text (i.e. > other than T***) meta tag frames providing a ff_id3v2_read_all() > function. An additional data structure 'ID3v2ExtraMeta' is introduced > for these tags since AVDictionary is string oriented and unsuitable > for binary data. > > A parser for tag frames of type GEOB is implemented, which is needed > to extract keyring information from encrypted OMA files. GEOB data > is parsed into 'ID3v2ExtraMetaGEOB' data structures. > > The routine to decode characters from different encodings to UTF-8, > formerly part of the read_ttag() function, is moved to its own > function. Because some tag frames contain subparts of unknown length, > the function is now also able to read until a null character is found. > In addition, the function now takes care of allocating a buffer long > enough to hold the decoded characters. > > Signed-off-by: David Goldwich <[email protected]> > --- > libavformat/id3v2.c | 270 > ++++++++++++++++++++++++++++++++++++++++++++------- > libavformat/id3v2.h | 38 +++++++- > 2 files changed, 270 insertions(+), 38 deletions(-) >
Looks mostly fine to me, I'll push the whole set soonish if there are no further comments. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
