On Wed, Oct 05, 2011 at 02:56:18PM +0300, Georgi Chorbadzhiyski wrote: > Around 10/05/2011 02:11 PM, Diego Biurrun scribbled: > > On Tue, Oct 04, 2011 at 10:27:36PM +0100, Måns Rullgård wrote: > >> Georgi Chorbadzhiyski <[email protected]> writes: > >>> > >>> When requesting debug info the user is already instructed to > >>> copy the full program output but in addition to that it needs > >>> to provide how the program was called. With this change all > >>> command line parameters that are used are shown in the output > >>> when verbose output is enabled. > >> > >> Are users now assumed too stupid to copy the command line they typed, > >> yet somehow capable of copying the same thing printed by the program. > >> Besides, printing it from within the program requires careful quoting to > >> make sure arguments containing whitespace or quotes are unambiguously > >> printed. I really don't think it's worth the effort. > > > > I'm with Georgi on this one and consider it a very worthwhile feature. > > I just had the same thoughts about the initial implementation that were > > already addressed. I'll test it tomorrow, let's see how it reacts to > > spaces, etc... > > The attached patch handles spaces and quotes. > > --- a/cmdutils.c > +++ b/cmdutils.c > @@ -474,13 +474,35 @@ static void print_all_libs_info(int flags, int level) > > av_log(NULL, AV_LOG_VERBOSE, " configuration: " LIBAV_CONFIGURATION > "\n"); > + av_log(NULL, AV_LOG_VERBOSE, " parameters :"); > + for (i=1; i<argc; i++) {
Please give the operators some space to breathe, more instances below. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
