Janne Grunau <[email protected]> writes: > On Thu, Oct 06, 2011 at 10:52:44AM +0100, Måns Rullgård wrote: >> Janne Grunau <[email protected]> writes: >> >> > preparation for NEON optimisations >> > --- >> > libavcodec/Makefile | 4 +- >> > libavcodec/rv30dsp.c | 3 + >> > libavcodec/rv34.c | 82 +------------------------------------ >> > libavcodec/rv34dsp.c | 108 >> > ++++++++++++++++++++++++++++++++++++++++++++++++++ >> > libavcodec/rv34dsp.h | 4 ++ >> > libavcodec/rv40dsp.c | 3 + >> > 6 files changed, 123 insertions(+), 81 deletions(-) >> > create mode 100644 libavcodec/rv34dsp.c >> >> Patch looks fine, but the commit message could be better. > > changed locally to "rv34: move inverse transform functions to DSP context" > > I think the reason is obvious enough and doesn't need to be mentioned in > the comit message
It was mainly the "preparation ..." part I didn't like. Dropping it entirely is fine. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
