On Thu, Oct 13, 2011 at 2:53 AM, Benjamin Larsson <[email protected]> wrote: > > Ok, I missread, anyway the ff_put_wav_header() function has a comment at > the top which says /* WAVEFORMATEX header */. So if the code doesn't > generate a WAVEFORMATEX header when there is no extradata then either > the documentation needs to be changed or the code fixed. > > http://msdn.microsoft.com/en-us/library/windows/desktop/dd390970(v=vs.85).aspx > > says > > "If no extra information is required by the wFormatTag, this member must > be set to zero. For WAVE_FORMAT_PCM formats (and only WAVE_FORMAT_PCM > formats), this member is ignored. However it is still recommended to set > the value." > > And not writing the cbSize doesn't make the header a WAVFORMAT one as > wBitsPerSample is written also. So if your description of the bug and > fix does what you say the patch is wrong. And the correct fix is to > always generate a valid header in ff_put_wav_header(). >
You're absolutely right; I had missed the wBitsPerSample field entirely. Thanks for pointing that out. I'll send a superseding patch to ff_put_wav_header shortly. The original patch can be discarded. - John _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
