On Wed, Oct 19, 2011 at 11:53:20AM -0700, Luca Barbato wrote: > It currently use the simple api and is ignoring the latency information > provided. > --- > configure | 4 + > libavdevice/Makefile | 1 + > libavdevice/alldevices.c | 1 + > libavdevice/pulse.c | 185 > ++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 191 insertions(+), 0 deletions(-) > create mode 100644 libavdevice/pulse.c
Run through the checklist again? :) This is missing docs and changelog update. > --- /dev/null > +++ b/libavdevice/pulse.c > @@ -0,0 +1,185 @@ > + > +/** > + * @file > + * Pulseaudio input > + * @author Luca Barbato <[email protected]> > + * > + * This avdevice decoder allows to capture audio from a Pulseaudio device > using > + * the simple api. > + * > + */ nit: stray empty line > +static pa_sample_format_t codec_id_to_pulse_format(int codec_id) { { on the next line > + switch(codec_id) { switch ( > + case CODEC_ID_PCM_U8: return PA_SAMPLE_U8; > + case CODEC_ID_PCM_ALAW: return PA_SAMPLE_ALAW; > + case CODEC_ID_PCM_MULAW: return PA_SAMPLE_ULAW; weird spacing Also, indent case statements at the same depth as the switch. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
