On Fri, 21 Oct 2011, Luca Barbato wrote:

On 10/21/11 1:01 PM, Martin Storsjö wrote:
From: Reimar Döffinger<[email protected]>

It does assume that only video would have keyframes and if there isn't video it wouldn't be possible to have a valid index.

I guess it might be nicer to have a way to support external indexes, surely passing null to av_add_index_entry isn't nice...

So would it be better like this then?

if ((vstream || astream) && other conditions)
    parse_keyframes(vstream ? vstream : astream, ...);

That would add the index entries to astream if there isn't any vstream, and doesn't crash if neither of them exist.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to