Le tridi 3 brumaire, an CCXX, Diego Biurrun a écrit :
> A changelog update and libavcodec version bump are missing,
> cf. the new formats checklist in the dev docs.

Sorry. Added. Although I do not know how it does not create a lot of
conflicts when applying asynchronously.

> Place this below libcdio, there used to be some order in that list.

Done.

> order please

Done, hopefully.

> ditto

Done.

> #include <celt/celt.h>
> #include <celt/celt_header.h>
> 
> #include "libavutil/intreadwrite.h"
> #include "avcodec.h"

Done.

> switch (

Done.

> What's with those #ifdefs?

The first is for compatibility with older libcelt versions, including
possibly some packaged by common distributions.

The second is for compatibility with some crappy Unix clone that people
still for some reason care about and that lacks this standard error code,
possibly macos.

> if (

Done.

> Align the last '=' as well.

It would go beyond 80 columns, and I did not find any combination that does
not make it look worse than the current version.

New patch incoming.

Regards,

-- 
  Nicolas George

Attachment: signature.asc
Description: Digital signature

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to